A soldier is "in" the military. You can be "in the army", "in the navy", "in the marines", etc.

If you're talking about someone who was a soldier in the past, say:

He was in the military

or

She's been in the military.